Use token name instead of provider name to check if the token is generated from oAuth #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinokurig
requested review from
akurinnoy,
olexii4 and
ibuziuk
as code owners
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1267 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1267", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
==========================================
- Coverage 91.67% 91.52% -0.15%
==========================================
Files 497 497
Lines 45501 45501
Branches 3167 3166 -1
==========================================
- Hits 41712 41646 -66
- Misses 3759 3826 +67
+ Partials 30 29 -1 ☔ View full report in Codecov by Sentry. |
akurinnoy
approved these changes
Nov 27, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use token name instead of provider name to check if the token is generated from oAuth
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23241
Is it tested? How?
quay.io/eclipse/che-dashboard:pr-1267User Preferences->Personal Access Tokenstab and add a GitHub token.Git Servicestab and see that the list is empty.Release Notes
With this fix, the dashboard User Preferences Git Services tab does not list git services by manually added Personal Access Tokens.
Docs PR