Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Devfile is not reachable warning for SSH urls (#1259) #1260

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

vinokurig
Copy link
Contributor

If the devfile resolve request fails with the devfile not found error, check if the url is an SSH url. If so, interrupt the workspace start with a new warning that describes the problem of the devfile resolve via a private repository SSH url.

What does this PR do?

cherry pick from #1259

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Is it tested? How?

Release Notes

Docs PR

Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot
Copy link
Contributor

che-bot commented Nov 20, 2024

Click here to review and test in web IDE: Contribute

If the devfile resolve request fails with the devfile not found error, check if the url is an SSH url. If so, interrupt the workspace start with a new warning that describes the problem of the devfile resolve via a private repository SSH url.
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1260

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1260", name: che-dashboard}]}}]"

@vinokurig vinokurig merged commit 797ee66 into 7.92.x Nov 20, 2024
13 checks passed
@vinokurig vinokurig deleted the CRW-7624_7.92 branch November 20, 2024 15:32
@devstudio-release
Copy link

Build 3.17 :: dashboard_3.17/22: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: dashboard_3.17/22: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.17/102 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: copyIIBsToQuay/2884: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.17/103: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.17/113 triggered; /job/DS_CI/job/dsc_3.17 triggered;

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.17/39: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.17/103 triggered

@devstudio-release
Copy link

Build 3.17 :: dsc_3.17/40: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: update-digests_3.17/356: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.17/39 triggered

@devstudio-release
Copy link

Build 3.17 :: dsc_3.17/40: SUCCESS

3.17.0-CI

@devstudio-release
Copy link

Build 3.17 :: copyIIBsToQuay/2884: SUCCESS

3.17
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.17-59
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.31-3
+ crwjen-3 IIB(s) copied:
  + quay.io/devspaces/iib:3.17-v4.17-866842-860560-s390x
  + quay.io/devspaces/iib:3.17-v4.17-s390x
  + quay.io/devspaces/iib:latest-v4.17-s390x
  + quay.io/devspaces/iib:3.17-v4.16-866841-860559-s390x
  + quay.io/devspaces/iib:3.17-v4.16-s390x
  + quay.io/devspaces/iib:latest-v4.16-s390x
  + quay.io/devspaces/iib:3.17-v4.15-868193-860558-s390x
  + quay.io/devspaces/iib:3.17-v4.15-s390x
  + quay.io/devspaces/iib:latest-v4.15-s390x
  + quay.io/devspaces/iib:3.17-v4.14-868192-860557-s390x
  + quay.io/devspaces/iib:3.17-v4.14-s390x
  + quay.io/devspaces/iib:latest-v4.14-s390x
  + quay.io/devspaces/iib:3.17-v4.13-868191-860556-s390x
  + quay.io/devspaces/iib:3.17-v4.13-s390x
  + quay.io/devspaces/iib:latest-v4.13-s390x
  + quay.io/devspaces/iib:3.17-v4.12-868190-860555-s390x
  + quay.io/devspaces/iib:3.17-v4.12-s390x
  + quay.io/devspaces/iib:latest-v4.12-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.17-v4.17-866842-860560-x86_64
  + quay.io/devspaces/iib:3.17-v4.17-x86_64
  + quay.io/devspaces/iib:latest-v4.17-x86_64
  + quay.io/devspaces/iib:3.17-v4.16-866841-860559-x86_64
  + quay.io/devspaces/iib:3.17-v4.16-x86_64
  + quay.io/devspaces/iib:latest-v4.16-x86_64
  + quay.io/devspaces/iib:3.17-v4.15-868193-860558-x86_64
  + quay.io/devspaces/iib:3.17-v4.15-x86_64
  + quay.io/devspaces/iib:latest-v4.15-x86_64
  + quay.io/devspaces/iib:3.17-v4.14-868192-860557-x86_64
  + quay.io/devspaces/iib:3.17-v4.14-x86_64
  + quay.io/devspaces/iib:latest-v4.14-x86_64
  + quay.io/devspaces/iib:3.17-v4.13-868191-860556-x86_64
  + quay.io/devspaces/iib:3.17-v4.13-x86_64
  + quay.io/devspaces/iib:latest-v4.13-x86_64
  + quay.io/devspaces/iib:3.17-v4.12-868190-860555-x86_64
  + quay.io/devspaces/iib:3.17-v4.12-x86_64
  + quay.io/devspaces/iib:latest-v4.12-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.17-v4.17-866842-860560-ppc64le
  + quay.io/devspaces/iib:3.17-v4.17-ppc64le
  + quay.io/devspaces/iib:latest-v4.17-ppc64le
  + quay.io/devspaces/iib:3.17-v4.16-866841-860559-ppc64le
  + quay.io/devspaces/iib:3.17-v4.16-ppc64le
  + quay.io/devspaces/iib:latest-v4.16-ppc64le
  + quay.io/devspaces/iib:3.17-v4.15-868193-860558-ppc64le
  + quay.io/devspaces/iib:3.17-v4.15-ppc64le
  + quay.io/devspaces/iib:latest-v4.15-ppc64le
  + quay.io/devspaces/iib:3.17-v4.14-868192-860557-ppc64le
  + quay.io/devspaces/iib:3.17-v4.14-ppc64le
  + quay.io/devspaces/iib:latest-v4.14-ppc64le
  + quay.io/devspaces/iib:3.17-v4.13-868191-860556-ppc64le
  + quay.io/devspaces/iib:3.17-v4.13-ppc64le
  + quay.io/devspaces/iib:latest-v4.13-ppc64le
  + quay.io/devspaces/iib:3.17-v4.12-868190-860555-ppc64le
  + quay.io/devspaces/iib:3.17-v4.12-ppc64le
  + quay.io/devspaces/iib:latest-v4.12-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants