-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Devfile is not reachable warning for SSH urls (#1259) #1260
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f89c83c
to
1b1c554
Compare
If the devfile resolve request fails with the devfile not found error, check if the url is an SSH url. If so, interrupt the workspace start with a new warning that describes the problem of the devfile resolve via a private repository SSH url.
1b1c554
to
8bc391c
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1260 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1260", name: che-dashboard}]}}]" |
Build 3.17 :: dashboard_3.17/22: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.17/102: Console, Changes, Git Data |
Build 3.17 :: push-latest-container-to-quay_3.17/90: Console, Changes, Git Data |
Build 3.17 :: get-sources-rhpkg-container-build_3.17/112: dashboard : 3.17 :: Build 65969211 : quay.io/devspaces/dashboard-rhel8:3.17-25 |
Build 3.17 :: update-digests_3.17/356: Console, Changes, Git Data |
Build 3.17 :: dashboard_3.17/22: Upstream sync done; /DS_CI/sync-to-downstream_3.17/102 triggered |
Build 3.17 :: operator-bundle_3.17/39: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.17/103: Console, Changes, Git Data |
Build 3.17 :: push-latest-container-to-quay_3.17/91: Console, Changes, Git Data |
Build 3.17 :: copyIIBsToQuay/2884: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.17/103: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.17/113 triggered; /job/DS_CI/job/dsc_3.17 triggered; |
Build 3.17 :: operator-bundle_3.17/39: Upstream sync done; /DS_CI/sync-to-downstream_3.17/103 triggered |
Build 3.17 :: dsc_3.17/40: Console, Changes, Git Data |
Build 3.17 :: update-digests_3.17/356: Detected new images: rebuild operator-bundle |
Build 3.17 :: dsc_3.17/40: 3.17.0-CI |
If the devfile resolve request fails with the devfile not found error, check if the url is an SSH url. If so, interrupt the workspace start with a new warning that describes the problem of the devfile resolve via a private repository SSH url.
What does this PR do?
cherry pick from #1259
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Is it tested? How?
Release Notes
Docs PR