Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade redux and react-redux packages #1251

Merged
merged 10 commits into from
Nov 14, 2024
Merged

chore: upgrade redux and react-redux packages #1251

merged 10 commits into from
Nov 14, 2024

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR aims to upgrade the redux and react-redux to the latest version and to align the project with these changes.

Screenshot/screencast of this PR

n/a

What issues does this PR fix or reference?

resolves eclipse-che/che#23178

Is it tested? How?

unit tests

@akurinnoy akurinnoy self-assigned this Nov 7, 2024
@che-bot
Copy link
Contributor

che-bot commented Nov 7, 2024

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 changed the title chore: upgrade react and react-redux packages fix: upgrade yarn.lock Nov 7, 2024
@olexii4 olexii4 changed the title fix: upgrade yarn.lock chore: upgrade react and react-redux packages Nov 7, 2024
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]"

1 similar comment
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]"

@akurinnoy akurinnoy changed the title chore: upgrade react and react-redux packages chore: upgrade redux and react-redux packages Nov 12, 2024
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]"

2 similar comments
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]"

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]"

@openshift-ci openshift-ci bot added the lgtm label Nov 13, 2024
Copy link

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 98.66053% with 32 lines in your changes missing coverage. Please review.

Project coverage is 91.54%. Comparing base (3d3945d) to head (a04a349).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...dashboard-frontend/src/services/assets/branding.ts 12.50% 14 Missing ⚠️
...s/dashboard-frontend/src/store/Branding/actions.ts 93.33% 6 Missing ⚠️
...dashboard-frontend/src/Layout/Navigation/index.tsx 0.00% 4 Missing ⚠️
...ges/dashboard-frontend/src/store/Events/actions.ts 98.41% 2 Missing ⚠️
...board-frontend/src/store/GitOauthConfig/actions.ts 98.99% 2 Missing ⚠️
...dashboard-frontend/src/services/bootstrap/index.ts 98.03% 1 Missing ⚠️
...rd-frontend/src/store/DevfileRegistries/reducer.ts 99.13% 1 Missing ⚠️
...shboard-frontend/src/store/DockerConfig/actions.ts 99.24% 1 Missing ⚠️
...d-frontend/src/store/Plugins/chePlugins/actions.ts 97.95% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
+ Coverage   90.09%   91.54%   +1.45%     
==========================================
  Files         445      497      +52     
  Lines       46094    45446     -648     
  Branches     3129     3156      +27     
==========================================
+ Hits        41527    41605      +78     
+ Misses       4531     3811     -720     
+ Partials       36       30       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akurinnoy akurinnoy merged commit 20a2a8c into main Nov 14, 2024
21 checks passed
@akurinnoy akurinnoy deleted the upgrade-redux branch November 14, 2024 09:54
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/588: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/8150: FAILURE

dashboard : 3.x :: Failed in 65909154 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dashboard dependencies: redux, react-redux
5 participants