-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade redux and react-redux packages #1251
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]" |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]" |
2 similar comments
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Oleksii Kurinnyi <[email protected]>
…act-redux packages
Signed-off-by: Oleksii Kurinnyi <[email protected]>
783399c
to
7e98ebd
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1251 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1251", name: che-dashboard}]}}]" |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1251 +/- ##
==========================================
+ Coverage 90.09% 91.54% +1.45%
==========================================
Files 445 497 +52
Lines 46094 45446 -648
Branches 3129 3156 +27
==========================================
+ Hits 41527 41605 +78
+ Misses 4531 3811 -720
+ Partials 36 30 -6 ☔ View full report in Codecov by Sentry. |
Build 3.18 :: dashboard_3.x/588: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/8073: Console, Changes, Git Data |
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8150: dashboard : 3.x :: Failed in 65909154 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
This PR aims to upgrade the
redux
andreact-redux
to the latest version and to align the project with these changes.Screenshot/screencast of this PR
n/a
What issues does this PR fix or reference?
resolves eclipse-che/che#23178
Is it tested? How?
unit tests