Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Added yarn v4 support #1250

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Added yarn v4 support #1250

wants to merge 1 commit into from

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Nov 6, 2024

What does this PR do?

Added yarn v4 support.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

It needs for https://issues.redhat.com/browse/CRW-7573

Is it tested? How?

Release Notes

Docs PR

@olexii4 olexii4 requested a review from SDawley November 6, 2024 15:16
@olexii4 olexii4 marked this pull request as ready for review November 6, 2024 15:18
@olexii4 olexii4 changed the title fix: babel plugins versions fix: upgrade yarn.lock Nov 7, 2024
@olexii4 olexii4 force-pushed the CRW-7573 branch 5 times, most recently from b8c2c2f to b461d98 Compare November 8, 2024 16:52
@eclipse-che eclipse-che deleted a comment from openshift-ci bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from openshift-ci bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from che-bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from codecov bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@eclipse-che eclipse-che deleted a comment from github-actions bot Nov 8, 2024
@olexii4 olexii4 changed the title fix: upgrade yarn.lock [DO NOT MERGE] Added yarn v4 support Nov 8, 2024
Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot
Copy link
Contributor

che-bot commented Nov 8, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Nov 8, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

1 similar comment
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (3d3945d) to head (753468f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
- Coverage   90.09%   89.89%   -0.20%     
==========================================
  Files         445      445              
  Lines       46094    46138      +44     
  Branches     3129     3105      -24     
==========================================
- Hits        41527    41477      -50     
- Misses       4531     4625      +94     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Oleksii Orel <[email protected]>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Nov 10, 2024

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-e2e-puppeteer b256be5 link true /test v14-e2e-puppeteer

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants