-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Added yarn v4 support #1250
base: main
Are you sure you want to change the base?
Conversation
b8c2c2f
to
b461d98
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]" |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
==========================================
- Coverage 90.09% 89.89% -0.20%
==========================================
Files 445 445
Lines 46094 46138 +44
Branches 3129 3105 -24
==========================================
- Hits 41527 41477 -50
- Misses 4531 4625 +94
Partials 36 36 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1250 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1250", name: che-dashboard}]}}]" |
@olexii4: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What does this PR do?
Added yarn v4 support.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
It needs for https://issues.redhat.com/browse/CRW-7573
Is it tested? How?
Release Notes
Docs PR