Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: versions of libraries #1239

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: versions of libraries #1239

merged 1 commit into from
Oct 28, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Oct 28, 2024

What does this PR do?

Fix versions of libraries.

What issues does this PR fix or reference?

It needs for https://issues.redhat.com/browse/CRW-7530

@che-bot
Copy link
Contributor

che-bot commented Oct 28, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1239

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1239", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1239

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1239", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1239

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1239", name: che-dashboard}]}}]"

@olexii4 olexii4 force-pushed the CRW-7530 branch 2 times, most recently from 3c3e1b8 to 32f7ce5 Compare October 28, 2024 05:43
@olexii4 olexii4 changed the title fix: version of glob library fix: versions of libraries Oct 28, 2024
@olexii4 olexii4 marked this pull request as ready for review October 28, 2024 05:47
Signed-off-by: Oleksii Orel <[email protected]>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1239

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1239", name: che-dashboard}]}}]"

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3efe8ae). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1239   +/-   ##
=======================================
  Coverage        ?   89.88%           
=======================================
  Files           ?      445           
  Lines           ?    46042           
  Branches        ?     3103           
=======================================
  Hits            ?    41386           
  Misses          ?     4616           
  Partials        ?       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 2383bdc into main Oct 28, 2024
21 checks passed
@olexii4 olexii4 deleted the CRW-7530 branch October 28, 2024 15:27
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/580: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/580: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7933 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7998: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 65462446 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants