-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix yamlResolver route #1004
Fix yamlResolver route #1004
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
=======================================
Coverage 86.50% 86.50%
=======================================
Files 383 383
Lines 39396 39397 +1
Branches 2580 2580
=======================================
+ Hits 34078 34079 +1
Misses 5292 5292
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4decef6
to
34af55a
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1004 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run yarn license:generate
in the root of the project to update lists of used dependencies.
|
You have changes in used dependencies in this particular pull request so you need to re-generate licenses for this PR. Otherwise, lists of used dependencies and licenses will not match. |
I have not generated license files yet. I created a separate PR because I want to separate license problems with more than 15 libraries that we have in the main branch from the scope of the current PR which removes one useless library. |
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1004 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1004 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1004", name: che-dashboard}]}}]" |
@olexii4: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.11 :: dashboard_3.x/409: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5429: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3805: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.x/5303: dashboard : 3.x :: Build 57274258 : quay.io/devspaces/dashboard-rhel8:3.11-35 |
Build 3.11 :: update-digests_3.x/5063: Console, Changes, Git Data |
Build 3.11 :: dashboard_3.x/409: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5429 triggered |
Build 3.11 :: operator-bundle_3.x/2338: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5430: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3806: Console, Changes, Git Data |
Build 3.11 :: copyIIBsToQuay/2223: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5430: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5304 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.11 :: operator-bundle_3.x/2338: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5430 triggered |
Build 3.11 :: dsc_3.x/1604: Console, Changes, Git Data |
Build 3.11 :: update-digests_3.x/5063: Detected new images: rebuild operator-bundle |
Build 3.11 :: dsc_3.x/1604: 3.11.0-CI |
What does this PR do?
Fix the '*.yaml' resolver route.
What issues does this PR fix or reference?
fixes eclipse-che/che#22456
Is it tested? How?