fix: update editor image method (#1053)

* fix: update editor image method Signed-off-by: Oleksii Orel <[email protected]>
eclipse-che · Feb 16, 2024 · 7ff8f04 · 7ff8f04
1 parent 9f0a1c6
commit 7ff8f04
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/...spaces/devWorkspaces/__tests__/fixtures/test-devworkspace-template-with-custom-image.yaml b/...spaces/devWorkspaces/__tests__/fixtures/test-devworkspace-template-with-custom-image.yaml
@@ -9,10 +9,10 @@ spec:
     - attributes:
         controller.devfile.io/container-contribution: true
       container:
-        image: test-images/che-code:tag
+        image: quay.io/devfile/universal-developer-image:next
       name: che-code-runtime-description
     - name: checode
       volume: {}
     - container:
-        image: quay.io/che-incubator/che-code:next
+        image: test-images/che-code:tag
       name: che-code-injector
diff --git a/...re/Workspaces/devWorkspaces/__tests__/fixtures/test-editor-devfile-with-custom-image.yaml b/...re/Workspaces/devWorkspaces/__tests__/fixtures/test-editor-devfile-with-custom-image.yaml
@@ -4,11 +4,11 @@ metadata:
 components:
   - name: che-code-runtime-description
     container:
-      image: test-images/che-code:tag
+      image: quay.io/devfile/universal-developer-image:next
     attributes:
       controller.devfile.io/container-contribution: true
   - name: checode
     volume: {}
   - name: che-code-injector
     container:
-      image: quay.io/che-incubator/che-code:next
+      image: test-images/che-code:tag
diff --git a/packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/editorImage.ts b/packages/dashboard-frontend/src/store/Workspaces/devWorkspaces/editorImage.ts
@@ -91,10 +91,7 @@ function updateComponents(
   }
   let isUpdated = false;
   for (let i = 0; i < components.length; i++) {
-    if (
-      components[i].attributes?.['controller.devfile.io/container-contribution'] &&
-      components[i].container?.image
-    ) {
+    if (components[i].name.endsWith('-injector') && components[i].container?.image) {
       components[i].container!.image = editorImage;
       isUpdated = true;
       break;