Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system configuration example with scripts and sample config files #11

Merged
merged 10 commits into from
Feb 20, 2024

Conversation

devkelley
Copy link
Contributor

Motivation and Context

This adds a set of configuration scripts and metadata files for configuring a sdv stack. This is needed for integrating individual services and will be valuable for the blueprint.
 

Description

system_config/params.yaml Fixed Show fixed Hide fixed
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several comments. Please take a look.

system_config/scripts/sys_config.sh Outdated Show resolved Hide resolved
system_config/scripts/sys_config.sh Outdated Show resolved Hide resolved
system_config/scripts/sys_config.sh Outdated Show resolved Hide resolved
system_config/scripts/sys_config.sh Outdated Show resolved Hide resolved
system_config/template/params.yaml Outdated Show resolved Hide resolved
system_config/sys_config.yaml Outdated Show resolved Hide resolved
@devkelley devkelley marked this pull request as ready for review February 17, 2024 01:07
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@ladatz ladatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two documentation suggestions

system_config/README.md Outdated Show resolved Hide resolved
system_config/README.md Show resolved Hide resolved
@devkelley devkelley merged commit 72b33ac into main Feb 20, 2024
6 checks passed
@devkelley devkelley deleted the devkelley/system_config_example branch February 20, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants