Improve display of vertical tree gridlines in timegraph views #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0.4.2 introduced vertical gridlines for the trees of timegraph views. However, 2 vertical lines were drawn so that they appeared thicker. This commit fixes that. Besides, the vertical line on the right of the last column are not drawn anymore. For that, the hideFiller flag needed to be added to the EntryTree props so that that flag can be set to true, propagated and hence the filler can be hidden. Signed-off-by: Bernd Hufmann <[email protected]>
MatthewKhouzam
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.4.2 introduced vertical gridlines for the trees of timegraph views (see #1152) . However, 2 vertical lines were drawn so that they appeared thicker. This commit fixes that.
Besides, the vertical line on the right of the last column are not drawn anymore. For that, the hideFiller flag needed to be added to the EntryTree props so that that flag can be set to true, propagated and hence the filler column can be hidden.
Here how it looks like with this PR:
Signed-off-by: Bernd Hufmann [email protected]