Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignalManager: improve type safety and reduce boilerplate #1133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SignalManager: improve type safety and reduce boilerplate #1133

wants to merge 1 commit into from
+284 −359

Commits on Nov 20, 2024

  1. SignalManager: improve type safety and reduce boilerplate 

    - Replace individual fire* methods with strongly-typed emit interface
- Consolidate signal payload types into single Signals interface
- Add type-safe event handler registration with overloaded on/off methods
- Remove redundant method declarations in favor of TypeScript inference
- Maintain full backward compatibility with existing event system

The new implementation provides compile-time type checking for event
payloads while significantly reducing code volume and maintenance burden.

Signed-off-by: Will Yang <[email protected]>
    @williamsyang-work
    williamsyang-work committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    1e8c9fc View commit details
    Browse the repository at this point in the history