Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new 'Open in Trace Viewer' command, add it to navigator context menu #1119

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Create a new 'Open in Trace Viewer' command, add it to navigator context menu #1119

merged 2 commits into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. Removed usage of Theia platform 'open-with' service 

    Signed-off-by: Marc Dumais <[email protected]>
    @marcdumais-work
    marcdumais-work committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1eabed7 View commit details
    Browse the repository at this point in the history

  2. Create a new 'Open in Trace Viewer' command, add it to navigator cont… 

    …ext menu

Starting around Theia v1.50.0, the "open-with" service no longer permitted to open
folders from the navigator context menu (only worked for files). It was possible to
make it work again, but there were undesirable side-effects. So instead, we decided
to register our own command, "Open in Trace Viewer", and add it to the navigator's
context menu at the first level. This is very similar to what we have on the `Trace
Viewer for VSCode` extension.

Also updated the README to reflect how a trace can now be be opened from the File
Explorer, and recorded a new .gif showing it.

Signed-off-by: Marc Dumais <[email protected]>
    @marcdumais-work
    marcdumais-work committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    85775c9 View commit details
    Browse the repository at this point in the history