Update to latest Theia community release: v1.52.0 #1118
Conversation
Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
theia-release-1.52.0
branch
from
27dd7a2
to
800a7ba
Compare
|
IP Tickets for the new dependencies: [main] INFO A review is required for npm/npmjs/-/app-builder-lib/24.13.3. |
marcdumais-work
force-pushed
the
theia-release-1.52.0
branch
2 times, most recently
from
3b22fc6
to
1915c36
Compare
Also ran yarn upgrade, to also update the other dependencies in the repo that might benefit, following the update of the Electron-related dependencies. With recent Theia, the rebuilding of the native dependencies for Electron does not work unless dependency "nan" is pinned to v2.18.0. For that reason, that dependency is added to this repo's root package.json's resolutions block. This issue highlighted that we do not perform a full build of the Electron app by default, leaving the rebuilding of the native dependencies (theia rebuild ...) to be done before starting the Electron app or packaging it. In consequence, it took a while to notice there was a problem with Electron once we upgraded to Theia v1.52.0. Also, update Jest test snapshots - there is a slight difference in the generated HTML code for one testcase, following the minor ag-grid update in this commit. Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
theia-release-1.52.0
branch
from
1915c36
to
34381f0
Compare
…till under review A few dependencies, that we beleive to be license-compatible with the project, but that are still under IP review, to the license check ignore list. For each one, the link to the IP ticket is provided. Signed-off-by: Marc Dumais <[email protected]>
|
Thanks for the review! |
This PR updates
@theiaextensiontheia-traceviewerso it uses the latest Theia community release (v1.52.0). Same for the browser and electron example applications in this repo.TODO:
Note: there is a separate PR (#1119) to deal with the "open-with" no longer working with folders, since Theia 1.50.0 IIRC. We will probably want to merge that one too, before publishing a new version of
theia-traceviewer. suitable for Theia 1.52.0 (latest community release)