Add webpack.config.js to docker example #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good. We just need to make sure you have a valid ECA. I sent a direct message regarding this, with more details. |
|
You can add this in your commit message, to link this PR to the corresponding issue that you opened: |
See contribution guide for more information about signing the ECA and other related topics. |
Some views like statistics view have features to right-click on the entries and select time ranges, but this feature requires some Node.js-specific features like "process", which is missing for the docker example. Fixes eclipse-cdt-cloud#1066 Signed-off-by: Siwei Zhang <[email protected]>
siwei-zhang-work
force-pushed
the
add-webpack-docker
branch
from
40fa7b4
to
394273e
Compare
|
@siwei-zhang-work the Eclipse Foundation |
marcdumais-work
approved these changes
May 7, 2024
There was a problem hiding this comment.
LGTM, thanks @siwei-zhang-work !
(note: I am not sure why but CI jobs other than ECA check did not trigger)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add webpack.config.js to example docker image.
Some views like statistics view have features to right-click on the entries and select time ranges, but this feature requires some Node.js-specific features like "process", which is missing for the docker example.
Fixes #1066
Signed-off-by: Siwei Zhang [email protected]