[CI] [UI tests] [Docker example] Build and test the docker example app, streamline it for size. #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
force-pushed
the
ci-build-docker-image
branch
30 times, most recently
from
f6d288c
to
55f9ed0
Compare
marcdumais-work
force-pushed
the
ci-build-docker-image
branch
from
2993db0
to
0528895
Compare
|
@frallax : FYI |
marcdumais-work
force-pushed
the
ci-build-docker-image
branch
2 times, most recently
from
02c20b9
to
c532e66
Compare
bhufmann
requested changes
Mar 15, 2024
|
@marcdumais-work I added some comments to this PR. |
marcdumais-work
force-pushed
the
ci-build-docker-image
branch
3 times, most recently
from
70d3730
to
59b381d
Compare
Bernd, I made some improvements following your comments, and tried to answer your questions. |
bhufmann
requested changes
Mar 21, 2024
marcdumais-work
force-pushed
the
ci-build-docker-image
branch
from
59b381d
to
8e9200a
Compare
bhufmann
previously approved these changes
Mar 21, 2024
marcdumais-work
force-pushed
the
ci-build-docker-image
branch
2 times, most recently
from
c86a05f
to
46f45b6
Compare
Build the docker example image Signed-off-by: Marc Dumais <[email protected]>
A few small changes that make the example docker image smaller and build a bit faster:
- Build the theia trace viewer app/appliance in "production" mode (vs development)
- Have yarn remove the installed "devDependencies" after the build ("yarn --production")
- adapt docker-entrypoint.sh to start the app directly rather than through @theia/cli
- Remove redundant "theia build" triggered in "prepare" package.json scripts entry - it's
also done in Dockerfile
Signed-off-by: Marc Dumais <[email protected]>
… a Trace Viewer appliance There is not necessarily a perfect solution here - all depends on how the resulting Docker image/appliance is intended to be used. Already, the fact that no support for vscode extension is provided, makes this app not suitable for use in software development. If we go to the logical conclusion, we can also remove a lot of the current @Theia framework extensions and make the app and resulting image smaller. One further potential improvement could be to make the trace viewer Theia extension not depend on @theia/preferences - currently the app pulls the relatively big @theia/monaco just for that. Instead, e.g. a static stub implementation could be used, just to set hardcoded values for the few preferences used in this app/appliance. Note: some extra @Theia extensions will be pulled as dependencies of the current list Signed-off-by: Marc Dumais <[email protected]>
… a few testcases Create a "trace viewer app" from the generic @theia/playwright "theiaApp" and add a "trace explorer view". Enhance test suite with some related test cases. Signed-off-by: Marc Dumais <[email protected]>
Since we have this minimal UI test suite, let's also use it on the browser example app. Signed-off-by: Marc Dumais <[email protected]>
The 3PP is believed to be license-compatible, according to the Eclipse Foundation rules Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
ci-build-docker-image
branch
from
46f45b6
to
944176a
Compare
bhufmann
approved these changes
Mar 25, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub workflow to build and test the example trace viewer Docker application/appliance
The tests were added by integrating
theia-playwright-template(*), and doing a bit of customising for the local integration. The result is a minimal UI test suite, that can be used on both the browser and Docker example applications (Electron support is also possible but was left-out for now). This is just the beginning of a test suite, that could be greatly enhanced, but it's better than nothing, specially to validate that the Docker example does not get badly broken without our knowledge.Along with the above, the Docker example app was streamlined, both in how it's built and to minimize the Theia extensions it uses, resulting in a nice decrease in resulting image size, hopefully without diminishing its applicability as a Trace Viewer appliance.
(*) https://github.com/eclipse-theia/theia-playwright-template/tree/d30db090063f40d56b1b1687851385e8ea33b599