Add Server Offline Landing to Placeholder Widget #1043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamsyang-work
force-pushed
the
server-offline-landing
branch
from
0c9f5d5
to
ff89b73
Compare
|
Putting this back into draft mode for the time being. |
williamsyang-work
force-pushed
the
server-offline-landing
branch
2 times, most recently
from
07f3f22
to
862a4a8
Compare
Adds a prompt to start the server when the front-end detects that there is no server currently running. This provides a clearer application flow for the user. Signed-off-by: Will Yang <[email protected]>
williamsyang-work
force-pushed
the
server-offline-landing
branch
from
b0376b6
to
2d5c012
Compare
bhufmann
reviewed
Feb 26, 2024
| const infoText = serverOn | ||
| ? 'You have not yet opened a trace.' | ||
| : 'No trace server instance is currently running.'; | ||
| const buttonText = serverOn ? 'Open Trace' : 'Resume Trace Extension'; |
There was a problem hiding this comment.
Shouldn't it be Reconnect instead of Resume Trace Extension?
| return ( | ||
| <ReactExplorerPlaceholderWidget | ||
| tracesOpen={tracesOpened} | ||
| serverOn={serverStatus} | ||
| handleStartServer={this.handleStartServer} |
There was a problem hiding this comment.
By the way, when porting this change to the vscode-trace-extension, the start server command is only available if vscode-trace-server is installed, which is not always the case. So, starting the trace should be handled there using the start/stop vscode API that is provided by the vscode-trace-extension and which extensions can contribute the start/stop functionality. The vscode-trace-server is contributing to that API.
|
Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a prompt to start the server when the front-end detects that there is no server currently running. This provides a clearer application flow for the user.
Starting a server that has no traces stored.
screen-capture.2.webm
Starting a server with traces stored.
screen-capture.3.webm
Signed-off-by: Will Yang [email protected]