Cleanup unused functions in cordova #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions are not really used anymore, and while the cost of maintaining them is not that high, it's still better to have less things to care about when updating, or when new users aks questions. This commit focuses mostly on the bindings, mostly because that's where most of the 'complexity' (duplication) is found, the underlying code is not really that problematic, but it may be good to remove it too. In any case, code can be retrieved from the history if necessary. - walletRestore - walletRetrieveFunds - walletConvert - conversionTransactionsSize - conversionTransactionsGet - conversionGetIgnored - walletPendingTransactions - pendingTransactionsSize - pendingTransactionsGet
ecioppettini
force-pushed
the
cleanup-unused-functions-in-cordova
branch
from
b2efbe1 to
6cf261a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.