-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix set temperature from HA #38
Conversation
oyvindwe
commented
Apr 4, 2024
- Allow temperature to be int
- Added tests for validations
- Run tests on GitHub
- Bump GitHub actions
- Version 1.8.1
- Allow temperature to be int - Added tests for validations - Run tests on GitHub - Bump GitHub actions - Version 1.8.1
I will test it tomorrow (friday) afternoon :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is looking fine by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And doing the review a second time with the correct username........
Question: If I want to test this, how am I supposed to test a library (pynobo.py) that is not yet published to pypi.org? |
It's a bit tricky. You need to change
See Custom requirements during development & testing I only do this in my development environment. I'll test HA later today before merging this PR. |
I have a spare rpi4 with HA on....... I have tested it and had no problems changing temperature and modes. That is the two things I tested, only. There was missing text in the config flow when it asked for the last 3 digits in the serial number. I am not sure why. It could be that I have copied the files to a custom component that something is missing. |
Works for me as well. Merging and releasing! |
Not missing for me. I suspect you did not copy the current translation file. |
@stigvi Please test with final version 1.8.1 as well and comment on home-assistant/core#114982 |
It's done. Looking good & working as expected. |