Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set temperature from HA #38

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

oyvindwe
Copy link
Collaborator

@oyvindwe oyvindwe commented Apr 4, 2024

  • Allow temperature to be int
  • Added tests for validations
  • Run tests on GitHub
  • Bump GitHub actions
  • Version 1.8.1

- Allow temperature to be int
- Added tests for validations
- Run tests on GitHub
- Bump GitHub actions
- Version 1.8.1
@oyvindwe oyvindwe requested review from stigvi and capelevy April 4, 2024 20:50
@oyvindwe
Copy link
Collaborator Author

oyvindwe commented Apr 4, 2024

Fixes home-assistant/core#114877

@stigvi
Copy link
Collaborator

stigvi commented Apr 4, 2024

I will test it tomorrow (friday) afternoon :-)

Copy link

@SVH-Powel SVH-Powel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking fine by me.

Copy link
Collaborator

@stigvi stigvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And doing the review a second time with the correct username........

@stigvi
Copy link
Collaborator

stigvi commented Apr 5, 2024

Question: If I want to test this, how am I supposed to test a library (pynobo.py) that is not yet published to pypi.org?

@oyvindwe
Copy link
Collaborator Author

oyvindwe commented Apr 5, 2024

Question: If I want to test this, how am I supposed to test a library (pynobo.py) that is not yet published to pypi.org?

It's a bit tricky. You need to change requirements in homeassistant/components/nobo_hub/manifest.json to

"requirements": "git+https://github.com/oyvindwe/pynobo.git@fix-set-temp#pynobo==1.8.1"

See Custom requirements during development & testing

I only do this in my development environment. I'll test HA later today before merging this PR.

@stigvi
Copy link
Collaborator

stigvi commented Apr 5, 2024

I only do this in my development environment. I'll test HA later today before merging this PR.

I have a spare rpi4 with HA on....... I have tested it and had no problems changing temperature and modes. That is the two things I tested, only.

There was missing text in the config flow when it asked for the last 3 digits in the serial number. I am not sure why. It could be that I have copied the files to a custom component that something is missing.

@oyvindwe
Copy link
Collaborator Author

oyvindwe commented Apr 5, 2024

Works for me as well. Merging and releasing!

@oyvindwe
Copy link
Collaborator Author

oyvindwe commented Apr 5, 2024

There was missing text in the config flow when it asked for the last 3 digits in the serial number.

Not missing for me. I suspect you did not copy the current translation file.

@oyvindwe oyvindwe merged commit e9b4e8d into echoromeo:master Apr 5, 2024
5 checks passed
@oyvindwe oyvindwe deleted the fix-set-temp branch April 5, 2024 19:38
@oyvindwe
Copy link
Collaborator Author

oyvindwe commented Apr 5, 2024

@stigvi Please test with final version 1.8.1 as well and comment on home-assistant/core#114982

@stigvi
Copy link
Collaborator

stigvi commented Apr 6, 2024

@stigvi Please test with final version 1.8.1 as well and comment on home-assistant/core#114982

It's done. Looking good & working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants