Merge pull request #1476 from ecency/bugfix/entry-image-fallback

Fixed entry list item image fallback
ecency · Oct 5, 2023 · 1bbb353 · 1bbb353
2 parents d1ef74d + a67357d
commit 1bbb353
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 17 deletions.
diff --git a/src/common/api/queries.ts b/src/common/api/queries.ts
@@ -79,7 +79,7 @@ export function useImageDownloader(
 
         return (await blobToBase64(response.data)) as string;
       } catch (e) {
-        return "";
+        return noImage;
       }
     },
     {

diff --git a/src/common/components/entry-list-item/entry-list-item-thumbnail.tsx b/src/common/components/entry-list-item/entry-list-item-thumbnail.tsx
@@ -40,26 +40,11 @@ export function EntryListItemThumbnail({ entry, noImage, isCrossPost, entryProp,
               src={imgGrid}
               alt={isGridLoading ? "" : entry.title}
               style={{ width: imgGrid === noImage ? "172px" : "auto" }}
-              onError={(e: React.SyntheticEvent) => {
-                const target = e.target as HTMLImageElement;
-                target.src = global.isElectron
-                  ? "./img/fallback.png"
-                  : require("../../img/fallback.png");
-              }}
             />
           ) : (
             <picture>
               <source srcSet={imgRow} media="(min-width: 576px)" />
-              <img
-                srcSet={imgRow}
-                alt={isRowLoading ? "" : entry.title}
-                onError={(e: React.SyntheticEvent) => {
-                  const target = e.target as HTMLImageElement;
-                  target.src = global.isElectron
-                    ? "./img/fallback.png"
-                    : require("../../img/fallback.png");
-                }}
-              />
+              <img srcSet={imgRow} alt={isRowLoading ? "" : entry.title} />
             </picture>
           )}
         </div>