-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable FilterEagerLoadingsExtension for better performance #6720
Open
pmattmann
wants to merge
2
commits into
ecamp:devel
Choose a base branch
from
pmattmann:feature/category-endpoint-performance
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Disable FilterEagerLoadingsExtension for better performance #6720
pmattmann
wants to merge
2
commits into
ecamp:devel
from
pmattmann:feature/category-endpoint-performance
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattmann
temporarily deployed
to
feature-branch
January 18, 2025 23:32 — with
GitHub Actions
Inactive
✅ Feature branch deployment ready!
|
Measurement of Prod-DB: Old: 1 - 4 SekSELECT
...
FROM
CATEGORY C0_
INNER JOIN CAMP C1_ ON C0_.CAMPID = C1_.ID
LEFT JOIN CATEGORY_CONTENTTYPE C8_ ON C0_.ID = C8_.CATEGORY_ID
LEFT JOIN CONTENT_TYPE C2_ ON C2_.ID = C8_.CONTENTTYPE_ID
INNER JOIN CONTENT_NODE C3_ ON C0_.ROOTCONTENTNODEID = C3_.ID
AND C3_.STRATEGY IN ('columnlayout')
LEFT JOIN CONTENT_NODE C4_ ON C3_.ROOTID = C4_.ID
AND C4_.STRATEGY IN ('columnlayout')
LEFT JOIN CONTENT_NODE C5_ ON C3_.PARENTID = C5_.ID
AND C5_.STRATEGY IN ('contentnode', 'columnlayout', checklistnode', 'storyboard', 'responsivelayout', 'singletext', 'materialnode', 'multiselect')
LEFT JOIN CONTENT_NODE C6_ ON C3_.ID = C6_.PARENTID
AND C6_.STRATEGY IN ('contentnode', 'columnlayout', checklistnode', 'storyboard', 'responsivelayout', 'singletext', 'materialnode', 'multiselect')
INNER JOIN CONTENT_TYPE C7_ ON C3_.CONTENTTYPEID = C7_.ID
WHERE
C0_.ID IN (
SELECT
C9_.ID
FROM
CATEGORY C9_
INNER JOIN CAMP C10_ ON C9_.CAMPID = C10_.ID
WHERE
C10_.ID = '882ef43cb000'
)
AND C0_.CAMPID IN (
SELECT
V11_.CAMPID AS SCLR_89
FROM
VIEW_USER_CAMPS V11_
WHERE
V11_.USERID = '8b3d14421000'
)
ORDER BY
C0_.CREATETIME DESC,
C1_.ID ASC,
C0_.SHORT ASC,
C2_.NAME ASC; New: ~80msSELECT
...
FROM
CATEGORY C0_
INNER JOIN CAMP C1_ ON C0_.CAMPID = C1_.ID
LEFT JOIN CATEGORY_CONTENTTYPE C8_ ON C0_.ID = C8_.CATEGORY_ID
LEFT JOIN CONTENT_TYPE C2_ ON C2_.ID = C8_.CONTENTTYPE_ID
INNER JOIN CONTENT_NODE C3_ ON C0_.ROOTCONTENTNODEID = C3_.ID
AND C3_.STRATEGY IN ('columnlayout')
LEFT JOIN CONTENT_NODE C4_ ON C3_.ROOTID = C4_.ID
AND C4_.STRATEGY IN ('columnlayout')
LEFT JOIN CONTENT_NODE C5_ ON C3_.PARENTID = C5_.ID
AND C5_.STRATEGY IN ('contentnode', 'columnlayout', checklistnode', 'storyboard', 'responsivelayout', 'singletext', 'materialnode', 'multiselect')
LEFT JOIN CONTENT_NODE C6_ ON C3_.ID = C6_.PARENTID
AND C6_.STRATEGY IN ('contentnode', 'columnlayout', checklistnode', 'storyboard', 'responsivelayout', 'singletext', 'materialnode', 'multiselect')
INNER JOIN CONTENT_TYPE C7_ ON C3_.CONTENTTYPEID = C7_.ID
WHERE
C0_.CAMPID = '882ef43cb000'
AND C0_.CAMPID IN (
SELECT
V11_.CAMPID AS SCLR_89
FROM
VIEW_USER_CAMPS V11_
WHERE
V11_.USERID = '8b3d14421000'
)
ORDER BY
C0_.CREATETIME DESC,
C1_.ID ASC,
C0_.SHORT ASC,
C2_.NAME ASC; |
Maybe judging by the name it allows to filter by some eager loaded relation? E.g. /camps/1a2b3c4d/categories?filter[color]=ff0000 or /camps/1a2b3c4d/activities?filter[category.color]=ff0000 or something similar? |
pmattmann
temporarily deployed
to
feature-branch
January 19, 2025 11:06 — with
GitHub Actions
Inactive
pmattmann
temporarily deployed
to
feature-branch
January 19, 2025 16:29 — with
GitHub Actions
Inactive
pmattmann
temporarily deployed
to
feature-branch
January 22, 2025 22:03 — with
GitHub Actions
Inactive
pmattmann
force-pushed
the
feature/category-endpoint-performance
branch
from
January 23, 2025 06:03
59a1b33
to
250bfa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-performance-test!
Run API Performance test
deploy!
Creates a feature branch deployment for this PR
Meeting Discuss
Am nächsten Core-Meeting besprechen
Performance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not clear to me what the filter
FilterEagerLoadingsExtension
is supposed to do.In our case, it ensures that the endpoint
/camps/111/categories
does not perform well.The filter rebuilds the SQL
from:
to: