Make build outliers SP support dynamic entity types #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring is motivated by the need to report on outliers for the entities in the new NHS primary care organisational structure.
builds
table now has anentities
array column which lists which entity types (e.g. ICB, PCN, STP, CCG) were used in the build of that dataset.The
build_outliers_dynamic
sp now requires thisentities
array as a parameter and operates over it to generate the required dynamic sql statements throughout.In order to present a consistent schema to the tables used in this dynamic sql, a per-entity-type view is created for each mapping the practice id (at which the primary level of aggregation is performed and stored in the
summed
table) to the id of the parent entity in question.