Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default ordering of PCNs #5078

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Set default ordering of PCNs #5078

merged 2 commits into from
Dec 2, 2024

Conversation

dracos
Copy link
Contributor

@dracos dracos commented Dec 1, 2024

This is so that on a page such as https://openprescribing.net/sicbl/15E/ the PCN list is shown in alphabetical order.

This is so that on a page such as https://openprescribing.net/sicbl/15E/  the PCN list is shown in alphabetical order.
@evansd
Copy link
Collaborator

evansd commented Dec 2, 2024

Thanks! I'm going to close and re-open this as that seems to be the easiest way to persuade Github that I really do want to run the test workflows even the ones which require authentication.

And also a nice opportunity to say, love your work Matthew! 👍

@evansd evansd closed this Dec 2, 2024
@evansd evansd reopened this Dec 2, 2024
@evansd
Copy link
Collaborator

evansd commented Dec 2, 2024

@dracos Ah, this isn't Black formatted and it's complaining that you've used single quotes instead of double-quotes. Not sure I can push to your branch to fix it though.

@dracos
Copy link
Contributor Author

dracos commented Dec 2, 2024

Sorry, fixed; yes, you should be able to edit my branch :) (And thanks!)

@evansd evansd merged commit 29b9478 into ebmdatalab:main Dec 2, 2024
7 of 10 checks passed
@evansd
Copy link
Collaborator

evansd commented Dec 2, 2024

Deployed now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants