Support changing file types in scmd import #4805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFISHER7
force-pushed
the
update-scmd-import
branch
from
c122849 to
9420e46
Compare
LFISHER7
changed the title
LFISHER7
force-pushed
the
update-scmd-import
branch
from
8f48704 to
67b1db6
Compare
Out of date months are months for which the existing file type attached to a month in the scmd table does not match that taken from the url. File type changes only go in one direction so we don't have to worry about what the file type changes to.
This way we can easily overwrite data for a given month when the file type has changed
LFISHER7
force-pushed
the
update-scmd-import
branch
from
67b1db6 to
99b0a0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the SCMD import script to support updating of monthly data subsets when they transition from provisional-->wip or wip-->finalised. Resolves https://github.com/ebmdatalab/op-hospitals/issues/20
To do so: