Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple AMPPs per GTIN #3722

Closed
wants to merge 4 commits into from
Closed

fix: multiple AMPPs per GTIN #3722

wants to merge 4 commits into from

Conversation

Jongmassey
Copy link
Collaborator

fixes #3721

@Jongmassey
Copy link
Collaborator Author

Jongmassey commented Oct 20, 2022 •
edited
Loading

Backing out of this one - it appears that the dmd-objs.json fixture don't support the case of multiple AMPPs for a given GTIN. I've done a hacky change to the test data but can't seem to get the management command to run in such a way as to generate the fixture with the required data

dependabot bot and others added 3 commits October 20, 2022 17:40
@dependabot @Jongmassey
chore(deps): bump oauthlib from 3.2.1 to 3.2.2
6066f25 
Bumps [oauthlib](https://github.com/oauthlib/oauthlib) from 3.2.1 to 3.2.2.
- [Release notes](https://github.com/oauthlib/oauthlib/releases)
- [Changelog](https://github.com/oauthlib/oauthlib/blob/v3.2.2/CHANGELOG.rst)
- [Commits](oauthlib/oauthlib@v3.2.1...v3.2.2)

---
updated-dependencies:
- dependency-name: oauthlib
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@Jongmassey
fix: multiple AMPPs per GTIN
3c766eb
@Jongmassey
hack: modify test fixture data
bd7e358
@Jongmassey Jongmassey force-pushed the multiple-ampp-for-gtin branch from a3309c7 to bd7e358 Compare October 20, 2022 16:42
@Jongmassey Jongmassey closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultipleObjectsReturned on GTIN search
1 participant
@Jongmassey