Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ACT tracker friendly to external devs #212

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

chadmiller
Copy link
Contributor

@chadmiller chadmiller commented May 20, 2019

The ACT tracker had several things that made it hard to follow the README.

  • FIle paths were hard-coded to the values of an internal machine.
  • It required a working, already set-up database daemon running.
  • Settings about services had to be set by a settings file that already exists.
  • Database migrations were sometimes specific to postgresql, instead of using django's common functions.

After this, anyone should be able to clone-load-run in three commands on a fresh, empty machine and have a working web site, and get immediate feedback.

Migrations are independent of database type. Settings have sensible, optional defaults (like sqlite for data backing).

One caveat is that the compute_ranks function had a CTI expression that was a bit bewildering to me, and I assumed things were actually simpler than the CTI suggests it should be. Windowing over date makes it seem like it stores historical data, and this no longer updates historical data.

Replaces many production-specific settings with more flexible values that need
not be set or need not be exactly the same as a production machine.
Make the README almost accurate, WRT ease of starting up a new instance.
Sqlite3 works just fine, if we enable it and refrain from using some psqlisms
and some advanced features like window function ROW_NUMBER (which is in
sqlite3, but not the version that's widely distributed yet).
@chadmiller chadmiller marked this pull request as ready for review May 20, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant