[Chore] Add solr json loader as submodule into index-bioentities repo

[ke4]

Changes:

• Added solr-jsonl-loader as a submodule
• Replaced solr-jsonl-chunk-loader.sh with a symlink that point to the similarly named file in the previously added submodule. That file in the submodule is going to be shared across other repositories, too.

[anilthanki]

Does this symlink perform same as actual file with all relative paths and bash commands like dirname etc

[ke4]

@anilthanki We extracted that single json chunk loader file into a separate repo. We are going to include that repo as a submodule in these repos:

• index-bioentities
• index-scxa
• solr-bulk
• maybe in index-gxa??? later

[anilthanki]

@anilthanki We extracted that single json chunk loader file into a separate repo. We are going to include that repo as a submodule in these repos:

• index-bioentities
• index-scxa
• solr-bulk
• maybe in index-gxa??? later

I totally agree we should not be maintaining multiple copies of same script, what I was asking is if its symlinked then certain relative functions (i.e. dirname) will behave same as actual file or do we need to change them?

[alfonsomunozpomer]

All good!

[alfonsomunozpomer]

All good!

[anilthanki]

LGTM

[pmb59]

LGTM!

My only comment is regarding this commit ec053f4. There, you are redefining and exporting, and already defined $SOLR_HOST variable. Why is this necessary only for this test and not for the other tests in tests/bioentities.bats?

[ke4]

LGTM!

My only comment is regarding this commit ec053f4. There, you are redefining and exporting, and already defined $SOLR_HOST variable. Why is this necessary only for this test and not for the other tests in tests/bioentities.bats?

@alfonsomunozpomer did that fix. As far as I remember without that fix the test wanted to connect to solr on localhost. That modification fixed that test. None of the other tests needed that change.