-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove db work mem #74
Conversation
1378d18
to
079521a
Compare
This has been rebased onto develop |
Whats the reason for sourcing |
This was part of rebasing this branch onto develop, which had to be done because the commit we use in the atlas-prod db-scxa submodule has diverged from db-scxa develop. If you compare fa23a2a and develop, you will see that a script has been sourced in fa23a2a but that script has since been replaced by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
I added 2 small comments/suggestions.
Could you check them please?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great and quick work!
Thanks for applying my suggestions!
LGTM and approved
Thanks @ke4 and @anilthanki! |
This removes setting database working memory for some postgres routines, which are causing the out-of-memory errors seen in single-cell experiment loading. It is also now rebasing onto develop from fa23a2a, and bringing changes from the latter onto the main branch.