Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove db work mem #74

Merged
merged 7 commits into from
Jun 14, 2024
Merged

Remove db work mem #74

merged 7 commits into from
Jun 14, 2024

Conversation

irisdianauy
Copy link
Contributor

@irisdianauy irisdianauy commented Jun 13, 2024

This removes setting database working memory for some postgres routines, which are causing the out-of-memory errors seen in single-cell experiment loading. It is also now rebasing onto develop from fa23a2a, and bringing changes from the latter onto the main branch.

@irisdianauy irisdianauy force-pushed the bugfix/remove_db_work_mem branch from 1378d18 to 079521a Compare June 14, 2024 10:19
@irisdianauy
Copy link
Contributor Author

This has been rebased onto develop

@irisdianauy irisdianauy marked this pull request as ready for review June 14, 2024 10:32
@anilthanki
Copy link

Whats the reason for sourcing common_routines.sh

@irisdianauy
Copy link
Contributor Author

irisdianauy commented Jun 14, 2024

Whats the reason for sourcing common_routines.sh

This was part of rebasing this branch onto develop, which had to be done because the commit we use in the atlas-prod db-scxa submodule has diverged from db-scxa develop. If you compare fa23a2a and develop, you will see that a script has been sourced in fa23a2a but that script has since been replaced by common_routines.sh in develop.

Copy link

@anilthanki anilthanki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ke4 ke4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
I added 2 small comments/suggestions.
Could you check them please?
Thanks

bin/load_db_scxa_dimred.sh Outdated Show resolved Hide resolved
bin/load_exp_design.sh Outdated Show resolved Hide resolved
@irisdianauy irisdianauy requested a review from ke4 June 14, 2024 13:43
Copy link
Contributor

@ke4 ke4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and quick work!
Thanks for applying my suggestions!
LGTM and approved

@irisdianauy irisdianauy merged commit 72ffd49 into develop Jun 14, 2024
1 check passed
@irisdianauy
Copy link
Contributor Author

Thanks @ke4 and @anilthanki!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants