Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve Anndata experiment page appearance #397

Merged
merged 6 commits into from
May 9, 2024

Conversation

ke4
Copy link
Contributor

@ke4 ke4 commented May 3, 2024

If the displayed experiment is an Anndata experiment then we use a different background colour for the experiment description section and add its icon to the right side of this section.

@ke4 ke4 added anndata improvement Improve/refactor existing code scxa labels May 3, 2024
@ke4 ke4 self-assigned this May 3, 2024
@ke4 ke4 linked an issue May 3, 2024 that may be closed by this pull request
@ke4 ke4 marked this pull request as ready for review May 8, 2024 10:31
@ke4 ke4 requested a review from lingyun1010 May 8, 2024 10:32
Copy link
Contributor

@lingyun1010 lingyun1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I suggest to add a tooltip for anndata icon for users to provide some hints that it stands for anndata in our website.

@ke4 ke4 requested a review from lingyun1010 May 9, 2024 10:40
Copy link
Contributor

@lingyun1010 lingyun1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please update to the latest develop before merging.

@ke4
Copy link
Contributor Author

ke4 commented May 9, 2024

LGTM! Please update to the latest develop before merging.

There is no conflict with the latest develop. I already updated this branch with develop in the morning.

@ke4 ke4 merged commit e3a7499 into develop May 9, 2024
3 checks passed
@ke4 ke4 deleted the feature/anndata_experiment_page branch May 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anndata improvement Improve/refactor existing code scxa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the title session of an Anndata experiment
2 participants