Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cell types endpoint #353

Merged
merged 22 commits into from
Nov 1, 2023
Merged

Refactor cell types endpoint #353

merged 22 commits into from
Nov 1, 2023

Conversation

ke4
Copy link
Contributor

@ke4 ke4 commented Aug 1, 2023 •
edited
Loading

Cell types endpoint need to process query params: organism parts, species and is marker gene.

ke4 added 14 commits February 1, 2023 14:51
@ke4
Pull and update latest submodule changes
ccfe8ff
@ke4
Merge branch 'develop' of https://github.com/ebi-gene-expression-grou…
7fecd55 
…p/atlas-web-single-cell into develop
@ke4
Merge branch 'develop' of https://github.com/ebi-gene-expression-grou…
98c88b3 
…p/atlas-web-single-cell into develop
@ke4
Merge branch 'develop' of https://github.com/ebi-gene-expression-grou…
d6ce88e 
…p/atlas-web-single-cell into develop
@ke4
Merge branch 'develop' of https://github.com/ebi-gene-expression-grou…
c3221ad 
…p/atlas-web-single-cell into develop
@ke4
Merge branch 'develop' of https://github.com/ebi-gene-expression-grou…
1bd1389 
…p/atlas-web-single-cell into develop
@ke4
Merge branch 'develop' of https://github.com/ebi-gene-expression-grou…
5ddb076 
…p/atlas-web-single-cell into develop
@ke4
Add organism part and cell type search to analytics search DAO
9b30847
@ke4
Merge branch 'develop' of https://github.com/ebi-gene-expression-grou…
ba67469 
…p/atlas-web-single-cell into feature/refactor_organism_part_endpoint
@ke4
Clean variable naming
c90387d
@ke4
Add cell types as an input parameter to OrganismPartSearchDao
5f79f72
@ke4
Add cell types as an input parameter to OrganismPartSearchService
2a61058
@ke4
clean code in JsonGeneSearchController
359c117
@ke4
remove unneeded JdbcUtils from CellTypeSearchDaoIT
1913dcf
@ke4 ke4 self-assigned this Aug 1, 2023
@ke4 ke4 added gene search high priority Do this first, then the rest labels Aug 1, 2023
@ke4 ke4 marked this pull request as ready for review August 4, 2023 15:05
@ke4 ke4 requested a review from alfonsomunozpomer August 4, 2023 15:05
@ke4 ke4 mentioned this pull request Sep 20, 2023
Closed
@ke4 ke4 linked an issue Sep 20, 2023 that may be closed by this pull request
Filter out null element from the resulted list from cell types endpoint #356
Closed
@ke4 ke4 requested review from upendrakumbham and removed request for alfonsomunozpomer October 3, 2023 10:10
upendrakumbham
upendrakumbham requested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@upendrakumbham upendrakumbham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor code improvements are required to merge, the rest of the code is good.

@ke4 ke4 removed the high priority Do this first, then the rest label Oct 12, 2023
upendrakumbham
upendrakumbham previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@upendrakumbham upendrakumbham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Please merge away!

@ke4 ke4 merged commit 198090b into develop Nov 1, 2023
2 checks passed
@ke4 ke4 deleted the feature/refactor_cell_types_endpoint branch November 1, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upendrakumbham upendrakumbham upendrakumbham left review comments

Assignees

@ke4 ke4

Labels
gene search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter out null element from the resulted list from cell types endpoint
2 participants
@ke4 @upendrakumbham