Fix CellTypeSearchDaoIT to filter for CTW_CELL_TYPE

ebi-gene-expression-group · Nov 25, 2024 · d3237ae · d3237ae
1 parent a533373
commit d3237ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/src/main/java/uk/ac/ebi/atlas/solr/SingleCellSolrUtils.java b/app/src/main/java/uk/ac/ebi/atlas/solr/SingleCellSolrUtils.java
@@ -45,6 +45,7 @@ public ImmutableSet<String> fetchedRandomOrganismPartsByCellIDs(ImmutableSet<Str
         SolrQueryBuilder<SingleCellAnalyticsCollectionProxy> queryBuilder = new SolrQueryBuilder<>();
         queryBuilder
                 .addQueryFieldByTerm(CELL_ID, cellIDs)
+                .exists(CTW_CELL_TYPE)
                 .setFieldList(CTW_ORGANISM_PART)
                 .setRows(MAX_ROWS);
 

diff --git a/app/src/test/java/uk/ac/ebi/atlas/search/celltype/CellTypeSearchDaoIT.java b/app/src/test/java/uk/ac/ebi/atlas/search/celltype/CellTypeSearchDaoIT.java
@@ -19,7 +19,6 @@
 
 import javax.inject.Inject;
 import javax.sql.DataSource;
-
 import java.util.HashSet;
 
 import static org.assertj.core.api.Assertions.assertThat;
@@ -183,8 +182,8 @@ void whenValidCellIdsAndValidProvidedReturnSetOfCellTypes() {
         var randomListOfCellIDs =
                 ImmutableSet.copyOf(
                         new HashSet<>(jdbcUtils.fetchRandomListOfCells(3)));
-        ImmutableSet<String> organismParts = solrUtils.fetchedRandomOrganismPartsByCellIDs(
-                randomListOfCellIDs, 1);
+        var organismParts = solrUtils.fetchedRandomOrganismPartsByCellIDs(
+            randomListOfCellIDs, 1);
 
         var cellTypes = subject.searchCellTypes(randomListOfCellIDs, organismParts);