Skip to content

Commit

Permalink
Bugfix eslint version mismatch (#485)
Browse files Browse the repository at this point in the history
* Remove the npm package update for modules

* Remove the mismatch devDependencies from cell type

wheel heatmap bundle

* Update package version to latest

* Bump frontend submodule eslint dependency version

* Filter out eslint-config package update by ncu

* Bump submodules versions for front end modules

* Fix a typo in readme
  • Loading branch information
lingyun1010 authored Nov 7, 2024
1 parent 3474e13 commit 9687cfa
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ For the first step you can run the following script:
./compile-front-end-packages.sh -iu
```

The sceond step is simply:
The second step is simply:
```bash
./gradlew :app:war
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
],
"license": "Apache-2.0",
"dependencies": {
"@ebi-gene-expression-group/scxa-cell-type-wheel-heatmap": "^1.4.14",
"@ebi-gene-expression-group/scxa-cell-type-wheel-heatmap": "^1.4.15",
"react": "^17.0.2",
"react-dom": "^17.0.2"
}
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/javascript/modules/experiments-summary-panel
2 changes: 1 addition & 1 deletion app/src/main/javascript/modules/species-summary-panel
5 changes: 3 additions & 2 deletions compile-front-end-packages.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@ while getopts ":iuph" opt; do
done

function update_npm_package {
# the latest version @ebi-gene-expression-group/eslint-config has conflict eslint version matching with some front-end components
if [ "$UPGRADE" = true ]; then
echo ">> $PWD$ ncu /@ebi-gene-expression-group/ --pre 1 -u"
ncu /@ebi-gene-expression-group/ --pre 1 -u
echo ">> $PWD$ ncu --filter /@ebi-gene-expression-group/ --pre 1 --reject @ebi-gene-expression-group/eslint -u "
ncu --filter '/@ebi-gene-expression-group.*/' --pre 1 --reject @ebi-gene-expression-group/eslint-config -u
fi
if [ "$INIT" = true ]; then
echo ">> $PWD$ rm -rf node_modules package-lock.json"
Expand Down

0 comments on commit 9687cfa

Please sign in to comment.