Fix initialisation order in DifferentialExperimentContrastLines's constructor #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structor buildContrastDetails method in the constructor using experimentDesign variable, hence it needs to initialise sooner
This was
linked to
issues
Nov 26, 2024
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment design variable was initialised after it was used in buildContrastDetails method in the constructor.
For this reason we got a NPE exception when we tried to use it in the buildContrastDetails method.
I had to swap the initialisation order in DifferentialExperimentContrastLines's constructor.
Unfortunately nobody wrote tests for this class. :-(
We need to merge and deploy this change ASAP.
I am going to add a ticket for writing tests and that is going to be done later, hopefully during next sprint.
Not very ideal. :-(