Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Batch email #68

Merged
merged 7 commits into from
Sep 18, 2024
Merged

feat: Batch email #68

merged 7 commits into from
Sep 18, 2024

Conversation

ranim-n
Copy link
Contributor

@ranim-n ranim-n commented Sep 13, 2024

No description provided.

@ranim-n ranim-n added the enhancement New feature or request label Sep 13, 2024
@ranim-n ranim-n self-assigned this Sep 13, 2024
@bobeal
Copy link
Member

bobeal commented Sep 14, 2024

  • there is a compilation error
  • there is also some noise

ranim-n and others added 3 commits September 16, 2024 09:33
@ranim-n ranim-n marked this pull request as ready for review September 17, 2024 07:29
@bobeal
Copy link
Member

bobeal commented Sep 17, 2024

  • there is a compilation error

    • there is also some noise

the noise is still there :(

@bobeal
Copy link
Member

bobeal commented Sep 17, 2024

  • there is a compilation error

    • there is also some noise

the noise is still there :(

I finally pushed a commit to do it myself (with some other minor improvements and fixes)

Those indentations are formatted by the editor automatically so I believed the noise you meant is in the way the code is written and not the format

@ranim-n
Copy link
Contributor Author

ranim-n commented Sep 18, 2024

@thomasBousselin

@ranim-n ranim-n merged commit 67765f5 into develop Sep 18, 2024
3 checks passed
@bobeal bobeal deleted the feature/batch-email branch September 19, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants