Organization context added #234
+28
−5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "id": "urn:ngsi-ld:UserProfile:123456789", | ||
| "type": "UserProfile", | ||
| "userInfos": { | ||
| "type": "JsonProperty", | ||
| "json": { | ||
| "familyName": "Smith", | ||
| "givenName": "John", | ||
| "email": "[email protected]" | ||
| } | ||
| }, | ||
| "organization": { | ||
| "type": "Property", | ||
| "value": "Agglomération Provence Verte" | ||
| } | ||
|
Comment on lines
+12
to
+15
There was a problem hiding this comment. if groups and groups membership are managed in KC, you can't duplicate them here (actually, Stellio already manages this info) There was a problem hiding this comment. We do this for SMBT though, for "Conch" & "Autre". That way can verify who has what access on the front via Admin account. For example, Admin user is approving an Authorization which has a relationship of "givenTo" which is a UserProfile id. That way we can then download the UserProfile and check which keys they have access to. Is there another way to achieve this? |
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a type, not an attribute? if so, it should be Organization.
and this one is better suited: https://schema.org/Organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, is it a group or an organization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both I suppose. They used the terminology "Organism". I can swap to Organization entities. Would be better to have them separate anyways for managing them (adding, deleting, updating)