Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update RoadWeather Project #613

Conversation

meteoDaniel
Copy link
Contributor

Relive of the ongoing implementation of DWD Road Weather Station data parsing

@meteoDaniel
Copy link
Contributor Author

meteoDaniel commented Mar 5, 2022

replacement of #528

Would be great to go on from here @gutzbenj .

If I understand you right, I just have to pass the metaindex object thourgh _all() method?

I think we should have a short chat where you give me the required hints to implement the last steps to fully interate to the existing API.

@gutzbenj
Copy link
Member

gutzbenj commented Mar 5, 2022

Dear @meteoDaniel ,

is there a specific reason why you're not using any of our core classes (ScalarRequestCore, ScalarValuesCore)[1] for the implementation? Those classes should already do most of the stuff you've rewritten again within your implementation.

[1] https://github.com/earthobservations/wetterdienst/tree/main/wetterdienst/core/scalar

Cheers
Benjamin

@gutzbenj
Copy link
Member

@meteoDaniel this can finally be closed :-)

@gutzbenj gutzbenj closed this Jun 15, 2023
@amotl
Copy link
Member

amotl commented Jun 15, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants