Fix an issue where no newline is present after the doctype when indent=no #5370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dizzz yes I saw that too. I will push updates soon. |
|
|
If you load XML via |
|
@dizzzz this PR does only change the behaviour of the doctype. |
adamretter
reviewed
Sep 2, 2024
| @@ -42,7 +42,7 @@ public void setUp() throws Exception { | |||
|
|
|||
| @Test | |||
| public void testAttributeWithBooleanValue() throws Exception { | |||
| final String expected = "<!DOCTYPE html>\n<input checked>"; | |||
| final String expected = "<!DOCTYPE html><input checked>"; | |||
There was a problem hiding this comment.
I am a bit confused. I thought the purpose of your change was to ensure that there was always a line break after the doctype declaration. Your changes to this test seem to show the opposite though.
| @@ -847,36 +847,39 @@ function ser:serialize-xml-134() { | |||
| }; | |||
|
|
|||
| declare | |||
| %test:assertEquals('<!DOCTYPE html> <option selected></option>') | |||
| %test:assertEquals('<!DOCTYPE html><option selected></option>') | |||
| "<!DOCTYPE bookmap PUBLIC \"-//OASIS//DTD DITA BookMap//EN\" \"bookmap.dtd\">\n" + | ||
| "<bookmap id=\"bookmap-1\"/>"; | ||
| "<!DOCTYPE bookmap PUBLIC \"-//OASIS//DTD DITA BookMap//EN\" \"bookmap.dtd\">" + | ||
| "<bookmap id=\"bookmap-1\"><title>The Title</title></bookmap>"; |
There was a problem hiding this comment.
Why add a child element here, it doesn't seem that it has changed anything else about the test?
adamretter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4736
Before
AFTER