-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] test on Java 11 #5304
base: develop-6.x.x
Are you sure you want to change the base?
[ci] test on Java 11 #5304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik / have seen, java11 causes an issue runtime (tar.gz) due to a signing issue/inconsistency. Only one jar file has this issue.
Be aware, eXist-db 6 is significantly less performant on JDK 11 than on JDK 8. |
@adamretter unfortunately JDK 8 is no longer available for the Mac OS Github action... |
Is it not possible to have a step that install a JDK? If I recall there is even a pre-build step for this in the GitHub Marketplace that can be used |
I was not aware of that..... or maybe I am. Any idea why? |
I just ask myself on how much effort are we willing to invest into that branch or should we try getting the next version out of the door? |
Runtime of tests was reasonable between 19 to 27 minutes for the entire test suite on java 11. In order for us to make sure that the existdb compiles and runs on java 8 as well we could add a separate test on java8 on linux workflow. How does that sound? |
I don't understand the point of this. eXist-db 6 targets Java 8, so changing CI to Java 11 makes no sense |
@adamretter I think using Java 11 to produce Java 8 byte code should be still ok instead of having investing a lot of time to handle an alternative Java setup instead. I think it would be better to consentrate on the next release instead and not wasting to much time in doing work-arounds for no longer supported build JDKs IMHO... |
I read/hear that the performance decline of java11 has been addresses in the JDK some time ago. |
Description:
Test on Java 11
Reference:
Type of tests: