-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orlo 0.4.3 #53
Merged
Merged
Orlo 0.4.3 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"sqlite://" is a problematic default because an in-memory database means having a separate database per-thread.
* Don't raise InvalidUsage without filters * Set default limit to 100 * Return 404 when no packages are found
orloclient will read this to find the orlo server
Changed the urls to return 404 if no results were found, this fixes the tests to account for that.
Requires a few if statements, but generally less repetition
`is` vs `==` ... I was under the impression that low ints were references to the same object. Bad to be exploiting this in any case.
Just use a url that doesn't return 404 if there are no packages
* Renamed exclude_partial_releases param to by_release * Added 'behaviour' section in config, with corresponding versions_by_release parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for what will become orlo 0.4.3, see commits for more details.
Bug fixes: