-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ucte converter #2498
base: develop
Are you sure you want to change the base?
Feature/ucte converter #2498
Conversation
…eature/ucte_converter
…eature/ucte_converter
…nged in some case which might be wrong, cf. Line2_DE
…eature/ucte_converter
…eature/ucte_converter
- fix breaking commit d8486f6 - fix geodata passing to create_bus
…eature/ucte_converter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
Thanks, @vogt31337 for your review and ideas! |
@mrifraunhofer can you also have a look? One remark: I structured the converter functionality |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2498 +/- ##
===========================================
+ Coverage 75.57% 75.85% +0.27%
===========================================
Files 284 288 +4
Lines 33811 34398 +587
===========================================
+ Hits 25554 26091 +537
- Misses 8257 8307 +50 ☔ View full report in Codecov by Sentry. |
This PR adds a converter to get pandapower network data from UCTE-DEF (UCTE Data Exchange Format)
The UCTE-DEF is a simple data format for electric transmission systems for the exchange of grid data introduced by the Union for the Co-ordination of Transmission of Electricity (UCTE), the predecessor of the ENTSO-E.
What is included, as well?
obj.GetAttributes(a)
instead ofobj.GetAttribute(a)
new_optimization_model_pandamodels.ipynb
What is included in other PR already?
required_std_type_parameters()
, cf. making available required standard type parameters #2479Maturity status
I think, it should be complete. Further refactoring can be done if there is ever time for it; as always.
Further remarks
The merge should be done as squash merge, I propose.