Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ucte converter #2498

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from

Conversation

SteffenMeinecke
Copy link
Member

@SteffenMeinecke SteffenMeinecke commented Dec 18, 2024

This PR adds a converter to get pandapower network data from UCTE-DEF (UCTE Data Exchange Format)

The UCTE-DEF is a simple data format for electric transmission systems for the exchange of grid data introduced by the Union for the Co-ordination of Transmission of Electricity (UCTE), the predecessor of the ENTSO-E.

What is included, as well?

  • [ADDED] API function rename_std_type()
  • [FIXED] default elements in toolbox function add_zones_to_elements()
  • [FIXED] from_powerfactory() converter: error that crept in obj.GetAttributes(a) instead of obj.GetAttribute(a)
  • [REMOVED] empty/deprecated tutorial new_optimization_model_pandamodels.ipynb
  • [CHANGED] e2n logo is updated due to its official renaming

What is included in other PR already?

Maturity status
I think, it should be complete. Further refactoring can be done if there is ever time for it; as always.

Further remarks
The merge should be done as squash merge, I propose.

Copy link
Contributor

@vogt31337 vogt31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

doc/pics/e2n.png Show resolved Hide resolved
pandapower/std_types.py Show resolved Hide resolved
pandapower/test/api/test_std_types.py Show resolved Hide resolved
doc/converter/ucte.rst Show resolved Hide resolved
@SteffenMeinecke
Copy link
Member Author

See comments.

Thanks, @vogt31337 for your review and ideas!

@SteffenMeinecke
Copy link
Member Author

SteffenMeinecke commented Jan 6, 2025

@mrifraunhofer can you also have a look?

One remark: I structured the converter functionality from_ucte() and its internal functions similar to the cim converter, although I don't see the advantage of creating an UCTEParser object and an UCTE2pandapower object. The reason of my opinion is that only data are converted and the object will never be reused or codings can be reused by using another object instead of the converter objects. In terms of the converter, one can easily think of input in UCTE format -> converter function -> output in pandapower format which perfectly fits to function-oriented coding rather than object-oriented coding. What is your opinion and why did you and others code the CIM converter like this?

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 90.54054% with 56 lines in your changes missing coverage. Please review.

Project coverage is 75.85%. Comparing base (0c11889) to head (4892efe).

Files with missing lines Patch % Lines
pandapower/converter/ucte/ucte_parser.py 81.57% 42 Missing ⚠️
pandapower/converter/ucte/ucte_converter.py 96.63% 11 Missing ⚠️
...ower/converter/powerfactory/pp_import_functions.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2498      +/-   ##
===========================================
+ Coverage    75.57%   75.85%   +0.27%     
===========================================
  Files          284      288       +4     
  Lines        33811    34398     +587     
===========================================
+ Hits         25554    26091     +537     
- Misses        8257     8307      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants