-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/integrate helm solver #2067
base: develop
Are you sure you want to change the base?
Feature/integrate helm solver #2067
Conversation
…40 iterations with an index error.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2067 +/- ##
===========================================
- Coverage 78.86% 78.66% -0.21%
===========================================
Files 213 214 +1
Lines 26541 26634 +93
===========================================
+ Hits 20932 20952 +20
- Misses 5609 5682 +73 ☔ View full report in Codecov by Sentry. |
I think there should be more tests for this implementation |
Furthermore, documentation and CHANGELOG should be extended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments above
still some bugs, for some networks results match, for others results don't match. I'm not sure why atm. Will investigate further. |
Hi,
I've created a PR which enables the use of the HELM method for pandapower. For this to function HELMPy needs to be installed. At the moment a modified Version must be used (this one here HELMPy), this version returns more values, for example if the method did converge and how many pade approximations needed to be done to reach the target accuracy.
BR