Fix failing tests #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test cases were passing when ran together, but they fail when ran individually. This has been fixed by making `urlSession` lazy. - The test case: `testProtocolReturnsErrorWithRegisteredStubError` had an ambiguous assertion on error. The test would pass even if other error than expected happened. This has been fixed by adding an assertion on the error domain.
- Test cases were passing when ran together, but they fail when ran individually. This was the case of test cases `testEphemeralSessionConfigurationIncludesProtocol` and `testDefaultSessionConfigurationIncludesProtocol`. Their failure was caused by the `MockingjayProtocol` not being added to `URLProtocol`'s registered classes. The registration happens normally when calling the `stub(_:_:)` method. As these two test cases didn't call it, they only pass if they run after other tests where `stub(_:_:)` was called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following: