-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest vulnerability fixes #962
Conversation
1. Updated ubuntu version to latest version. This fixes libgnutls30 package. 2. Cryptography package updated to suggested version. 3. Updated bash package to latest version manually. Latest Ubuntu version still contains vulnerable package so had to manually upgrade.
Can you upload link for the docker website or screenshot for AWS? I would like to verify this before merging.
We have a fairly robust process for server updates (unit tests/staging, etc), so we should not rule it out in general. But noble looks like it is still |
CVE ID (CVE-2022-3715) refers to same bash package vulnerability in both Docker and AWS, and both of the links identify it as MEDIUM, while AWS identifies it as HIGH. CVE link from Docker image Docker image ubuntu:jammy-20240227 available here. While in AWS ECR the same bash package is tagged as HIGH severity (see screenshot below) |
@MukuFlash03 that's interesting. I am going to merge this for now because more fixed is better than less fixed, but we may want to follow up with the cloud services team to understand this discrepancy and how it should be resolved in the future. |
|
||
# Clean up the conda install | ||
conda clean -t | ||
find /root/miniconda-*/pkgs -wholename \*info/test\* -type d | xargs rm -rf | ||
find ~/miniconda-23.5.2 -name \*tests\* -path '*/site-packages/*' | grep ".*/site-packages/tests" | xargs rm -rf | ||
|
||
# Updating bash package to latest version manually | ||
apt-get update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is likely to bump up the image size significantly because of the downloaded packages for update
. Can you see if that is true by comparing image sizes after this is built? If so, in a cleanup PR, please delete the downloaded packages (e.g. apt clean
or similar).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe what you are referring to happens when we actually "upgrade" the packages using apt-get upgrade
while "update"-ing the packages using apt-get update
just downloads the latest list of available packages but not the actual package versions themselves.
More information here and here:
The apt-get update downloads the index files whereas the apt-get upgrade downloads the latest versions packages of the installed packages.
Also, I checked the image sizes with and without the update command and there wasn't a significant difference in the sizes.
So, we should be good with this change.
@Abby-Wheelis for visibility around DevOps changes |
Summary
4 HIGH severity vulnerabilities: cryptography, libgnutls30 (2), bash
DETAILED
1. bash
Installed: 0:5.1-6ubuntu1.AMD64
Fixed: 0:5.1-6ubuntu1.1
Findings:
So, cannot risk downloading this image.
Approach planned:
Actions taken:
Resources: 1, 2
$ apt-get install bash=5.1-6ubuntu1.1
Failed initially with error:
Solved this by running apt-get update (read here)
Then ran the install command again.
Working now. "bash" package successfully updated.
—————
2. libgnutls30
2 vulnerabilities present for this library.
Installed: 0:3.7.3-4ubuntu1.3.AMD64
Fixed: 0:3.7.3-4ubuntu1.4
Upgrading to
ubuntu:jammy-20240227
for now, which has the fixed libgnutls30 version.But this has bash vulnerability which was handled manually (see 1 above)
————————
Upgraded version from 41.0.7 to 42.0.0
$ conda install -c conda-forge cryptography=42.0.0 wheel=0.40.0
Removed older version files
$ rm -rf /root/miniconda-23.5.2/lib/python3.9/site-packages/cryptography-41.0.7.dist-info
Tested by “cd” ing into folder, verified that 41.0.7 no longer present, 42.0.0 is the latest version in these locations: