Skip to content

Commit

Permalink
Formatting change
Browse files Browse the repository at this point in the history
Adding spaces to see if that fixes the secret not being set. Also, trying to access the variables directly without using the get method.
  • Loading branch information
nataliejschultz committed Sep 19, 2023
1 parent 2b0c1e6 commit 1ddc01b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/nominatim-docker-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:

- name: Test nominatim
env:
GEOFABRIK_QUERY_URL: "https://geocoding.geofabrik.de/${{secrets.GEOFABRIK_API}}"
TEST_KEY: ${{secrets.TEST_SECRET}}
TEST_ENVVAR: "https://geocoding.geofabrik.de/${{secrets.TEST_SECRET}}"
GEOFABRIK_QUERY_URL: "https://geocoding.geofabrik.de/${{ secrets.GEOFABRIK_API }}"
TEST_KEY: ${{ secrets.TEST_SECRET }}
TEST_ENVVAR: "https://geocoding.geofabrik.de/${{ secrets.TEST_SECRET }}"
TEST_STR: "https://geocoding.geofabrik.de/"
run: docker-compose -f emission/integrationTests/docker-compose.yml up --exit-code-from web-server
2 changes: 2 additions & 0 deletions emission/individual_tests/TestNominatim.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

print("Starting to test Nominatim")
#temporarily sets NOMINATIM_QUERY_URL to the environment variable for testing.
print("testkey", TEST_KEY)
print("testenvvar", TEST_ENVVAR)
NOMINATIM_QUERY_URL_env = os.environ.get("NOMINATIM_QUERY_URL", "")
NOMINATIM_QUERY_URL = NOMINATIM_QUERY_URL_env if NOMINATIM_QUERY_URL_env != "" else eco.NOMINATIM_QUERY_URL
GEOFABRIK_QUERY_URL = os.environ.get("GEOFABRIK_QUERY_URL")
Expand Down

0 comments on commit 1ddc01b

Please sign in to comment.