Skip to content

Commit

Permalink
Remove NOP if statement
Browse files Browse the repository at this point in the history
I added this as part of the
#825 PR to try and duplicate
this special case handling of the enketo code
https://github.com/e-mission/e-mission-phone/blob/59690cb503c682cf09b3681db70aeafa8d4631c0/www/js/diary/services.js#L1127

However, I actually ended up handling it at
https://github.com/e-mission/e-mission-phone/pull/825/files#diff-4d928ea1f0def79e554ae472efcde3c3cfb464593833e77b9bc4dae5017bd244R1140 (in `readTripsAndUnprocessedInputs` instead)

So this NOP `if` statement is no longer required
  • Loading branch information
shankari committed May 9, 2022
1 parent 73bc4ab commit 9f3ac2e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions www/js/diary/services.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

angular.module('emission.main.diary.services', ['emission.plugin.logger',
'emission.services', 'emission.main.common.services',
'emission.incident.posttrip.manual', 'emission.survey.multilabel.services', 'emission.survey.enketo.answer'])
'emission.incident.posttrip.manual', 'emission.survey.enketo.answer'])
.factory('DiaryHelper', function(CommonGraph, PostTripManualMarker, $translate){
var dh = {};
// dh.expandEarlierOrLater = function(id) {
Expand Down Expand Up @@ -1111,8 +1111,6 @@ angular.module('emission.main.diary.services', ['emission.plugin.logger',
console.log(mrString);
timeline.data.unifiedConfirmsResults = {}
manualResults.forEach(function(mr, index) {
if (ConfirmHelper.INPUTS[index].key == "manual/survey_response") {
}
timeline.data.unifiedConfirmsResults[ConfirmHelper.INPUTS[index]] = mr;
});
}
Expand Down

0 comments on commit 9f3ac2e

Please sign in to comment.