Turn off UI alerts unless the user wants them for debugging #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User wants them == "simulateUserInteraction" Unlike iOS, this does not introduce a new dependency, it does have a lot of repeated code, specially in the services when we try to transition to a new state. Fixing it is being tracked in e-mission#113 Note that the iOS change changes the logging directly, so it is not checked into this repo. The iOS change is at: shankari/cordova-unified-logger@f55fc2d This is an object case in the pitfalls of both approaches - we just need to refactor and do them right on the second pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User wants them == "simulateUserInteraction"
Unlike iOS, this does not introduce a new dependency, it does have a lot of
repeated code, specially in the services when we try to transition to a new
state.
Fixing it is being tracked in
#113
Note that the iOS change changes the logging directly, so it is not checked
into this repo. The iOS change is at:
shankari/cordova-unified-logger@f55fc2d
This is an object case in the pitfalls of both approaches - we just need to
refactor and do them right on the second pass.