gitBranchExpression should override local git branch if provided #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
override git branch detection. When the environment variable expression provided by 'gitBranchExpression' resolves to some branch name, that was being ignored in favor of the git branch detected by reading the local git metadata. Now the local git branch is only used if that variable is missing or doesn't fully resolve.
Pull Request Test Coverage Report for Build 379
💛 - Coveralls |
|
To clarify: This is a question of priority, correct? You're wanting the environment variable to override whatever would be detected from the git metadata. That seems reasonable. Any chance I can talk you into providing test cases to enforce this semantic? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
gitBranchExpressionto provide the git branch name via environment variables, intending to override the git branch name as can be detected via the git metadata on the filesystem. Since the addition of detecting the git branch name from the local git metadata was added the use of the environment variable seems to have been dropped.This PR restores that behavior. Now if the environment variable resolves to some string that doesn't contain any additional replacement characters (
${ }) it will be used, even if the local git metadata could provide a branch name. The actual git branch name will only be used if thegitBranchExpressionis not provided, or doesn't fully resolve.