🐛 fix(user-simulator): Fix user-simulator not properly terminating #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en an error occurs Cleanup type usage
W3D3
force-pushed
the
bugfix/fix-user-simulator-hanging
branch
from
0b55ee7
to
14214b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
user-simulatorhanging when something goes wrong during execution. It will now properly terminate the process with a non-zero exit code.Additionally, before trying to log out, the simulator will navigate to the homepage to make sure the logout button is available to click.
Screenshot of execution with a fake error thrown:
Also used the opportunity to clean up the type usage.
Fixes #82 .