Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 ci: add skaffold build ci action #41

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Conversation

W3D3
Copy link
Contributor

@W3D3 W3D3 commented Mar 16, 2023

This PR adds two new GitHub actions:

  • One action that is run on every PR that simply builds all the images as a very weak form of catching errors that break the whole application
  • One action that is run on pushing to a release branch, that builds and pushes the images to GHCR
    • Images are tagged with {version} based on the branch name release/{version}.

@W3D3 W3D3 force-pushed the add-skaffold-build-ci-action branch 3 times, most recently from 557c647 to d671fae Compare March 16, 2023 09:14
@W3D3 W3D3 force-pushed the add-skaffold-build-ci-action branch 13 times, most recently from 43990b1 to ecdb70b Compare March 24, 2023 13:44
@W3D3 W3D3 marked this pull request as ready for review March 24, 2023 13:52
@W3D3 W3D3 requested a review from a team as a code owner March 24, 2023 13:52
@W3D3 W3D3 requested a review from ammerzon March 24, 2023 13:54
@W3D3 W3D3 force-pushed the add-skaffold-build-ci-action branch from ecdb70b to 09a46cc Compare March 24, 2023 13:58
Copy link
Contributor

@ammerzon ammerzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these workflows, so we finally have the images on GHCR 😁

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@ammerzon ammerzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. One general question regarding the commits. Do we have a convention on whether the commit message after the component type should start with an upper case or lower case letter?

CleanShot 2023-03-27 at 11 16 43

@W3D3
Copy link
Contributor Author

W3D3 commented Mar 27, 2023

Approved. One general question regarding the commits. Do we have a convention on whether the commit message after the component type should start with an upper case or lower case letter?

CleanShot 2023-03-27 at 11 16 43

The commitlint action currently doesn't check, but I don't have any strong feelings on how it should be.

@W3D3 W3D3 merged commit 21d9943 into main Mar 27, 2023
@ammerzon
Copy link
Contributor

Same. We could use the format with the uppercase letter because most of the older commits are written this way.

CleanShot 2023-03-28 at 11 20 54

@W3D3
Copy link
Contributor Author

W3D3 commented Mar 28, 2023

Same. We could use the format with the uppercase letter because most of the older commits are written this way.

We'll just have to extend the commitlint.config.js with a rule that forces sentence case for the body then.
See: https://github.com/conventional-changelog/commitlint/blob/master/docs/reference-rules.md#body-case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants