Begin incorporating notebook from trapping_extended and aligning __init__
#510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * change global rng to explicit rng (np.random.Generator) * Fix latex error (removing \label) for local build WIP
A bit wonky MHD images, and slightly less OOM good performance. But term indexes look correct, no? WIP
Seem to be doing better with the optimizer steps, but too large deviation from
constraints, leading to solution with As indefinite (some eigvals > 0)
Also:
check_stability now returns False if not stable (and avoids printing)
WIP
Add beta, alpha, mod_matrix, remove relax_optim relax_optim = `False` tried to directly minimize eigenvalues of A, rather than applying trapping theorem. This resulted in a nonconvex problem (convex composite) that did not work well.
Jacob-Stevens-Haas
force-pushed
the
trapping-resolve
branch
from
3ddb3ba to
2fc5fcd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
==========================================
- Coverage 94.70% 94.68% -0.02%
==========================================
Files 38 38
Lines 4114 4105 -9
==========================================
- Hits 3896 3887 -9
Misses 218 218 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft - still need to properly handle relax_optim