feat(optimizers): Enable pickling of MIOSR optimizer #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #456 Implement __setstate__ and __getstate__ methods for MIOSR AFAIK, we don't need to mess with __reduce__ Add a new test for the pickle-ability of optimizers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
==========================================
+ Coverage 93.87% 93.89% +0.01%
==========================================
Files 37 37
Lines 3627 3634 +7
==========================================
+ Hits 3405 3412 +7
Misses 222 222 ☔ View full report in Codecov by Sentry. |
jpcurbelo
pushed a commit
to jpcurbelo/pysindy_fork
that referenced
this pull request
Apr 30, 2024
Fixes dynamicslab#456 Implement __setstate__ and __getstate__ methods for MIOSR AFAIK, we don't need to mess with __reduce__ Add a new test for the pickle-ability of optimizers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a reference implementation of option 3 in #456 . At the time, I didn't know about
__setstate__and__getstate__, but these are simpler and more straightforwards than__reduce__.Test fails on master, passes on this branch.
Most of this change is from the example here.