BUG: Set mutable default function_library in __init__() body

dynamicslab · Jan 3, 2024 · f737ae1 · f737ae1
1 parent e641dce
commit f737ae1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/pysindy/feature_library/pde_library.py b/pysindy/feature_library/pde_library.py
@@ -1,5 +1,6 @@
 import warnings
 from itertools import product as iproduct
+from typing import Optional
 
 import numpy as np
 from sklearn.utils.validation import check_is_fitted
@@ -85,9 +86,7 @@ class PDELibrary(BaseFeatureLibrary):
 
     def __init__(
         self,
-        function_library: BaseFeatureLibrary = PolynomialLibrary(
-            degree=3, include_bias=False
-        ),
+        function_library: Optional[BaseFeatureLibrary] = None,
         derivative_order=0,
         spatial_grid=None,
         temporal_grid=None,
@@ -110,7 +109,8 @@ def __init__(
         self.num_trajectories = 1
         self.differentiation_method = differentiation_method
         self.diff_kwargs = diff_kwargs
-
+        if function_library is None:
+            self.function_library = PolynomialLibrary(degree=3, include_bias=False)
         if derivative_order < 0:
             raise ValueError("The derivative order must be >0")
 

diff --git a/pysindy/feature_library/weak_pde_library.py b/pysindy/feature_library/weak_pde_library.py
@@ -1,5 +1,6 @@
 import warnings
 from itertools import product as iproduct
+from typing import Optional
 
 import numpy as np
 from scipy.special import binom
@@ -135,9 +136,7 @@ class WeakPDELibrary(BaseFeatureLibrary):
 
     def __init__(
         self,
-        function_library: BaseFeatureLibrary = PolynomialLibrary(
-            degree=3, include_bias=False
-        ),
+        function_library: Optional[BaseFeatureLibrary] = None,
         derivative_order=0,
         spatiotemporal_grid=None,
         interaction_only=True,
@@ -166,6 +165,8 @@ def __init__(
         self.num_trajectories = 1
         self.differentiation_method = differentiation_method
         self.diff_kwargs = diff_kwargs
+        if function_library is None:
+            self.function_library = PolynomialLibrary(degree=3, include_bias=False)
 
         if spatiotemporal_grid is None:
             raise ValueError(